linux-kernel - Re: [PATCH] perf stat: Align the output for interval aggregation mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200220105355.GA553812@krava>
Date:   Thu, 20 Feb 2020 11:53:55 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH] perf stat: Align the output for interval aggregation mode

On Tue, Feb 18, 2020 at 03:16:14PM +0800, Jin Yao wrote:
> There is a slight misalignment in -A -I output.
> 
> For example,
> 
>  perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> 
>  #           time CPU                    counts unit events
>       1.000440863 CPU0               1,068,388      cpu/event=cpu-cycles/
>       1.000440863 CPU1                 875,954      cpu/event=cpu-cycles/
>       1.000440863 CPU2               3,072,538      cpu/event=cpu-cycles/
>       1.000440863 CPU3               4,026,870      cpu/event=cpu-cycles/
>       1.000440863 CPU4               5,919,630      cpu/event=cpu-cycles/
>       1.000440863 CPU5               2,714,260      cpu/event=cpu-cycles/
>       1.000440863 CPU6               2,219,240      cpu/event=cpu-cycles/
>       1.000440863 CPU7               1,299,232      cpu/event=cpu-cycles/
> 
> The value of counts is not aligned with the column "counts" and
> the event name is not aligned with the column "events".
> 
> With this patch, the output is,
> 
>  perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> 
>  #           time CPU                    counts unit events
>       1.000423009 CPU0                  997,421      cpu/event=cpu-cycles/
>       1.000423009 CPU1                1,422,042      cpu/event=cpu-cycles/
>       1.000423009 CPU2                  484,651      cpu/event=cpu-cycles/
>       1.000423009 CPU3                  525,791      cpu/event=cpu-cycles/
>       1.000423009 CPU4                1,370,100      cpu/event=cpu-cycles/
>       1.000423009 CPU5                  442,072      cpu/event=cpu-cycles/
>       1.000423009 CPU6                  205,643      cpu/event=cpu-cycles/
>       1.000423009 CPU7                1,302,250      cpu/event=cpu-cycles/
> 
> Now output is aligned.
> 
> Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka

> ---
>  tools/perf/util/stat-display.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index bc31fccc0057..95b29c9cba36 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -114,11 +114,11 @@ static void aggr_printout(struct perf_stat_config *config,
>  			fprintf(config->output, "S%d-D%d-C%*d%s",
>  				cpu_map__id_to_socket(id),
>  				cpu_map__id_to_die(id),
> -				config->csv_output ? 0 : -5,
> +				config->csv_output ? 0 : -3,
>  				cpu_map__id_to_cpu(id), config->csv_sep);
>  		} else {
> -			fprintf(config->output, "CPU%*d%s ",
> -				config->csv_output ? 0 : -5,
> +			fprintf(config->output, "CPU%*d%s",
> +				config->csv_output ? 0 : -7,
>  				evsel__cpus(evsel)->map[id],
>  				config->csv_sep);
>  		}
> -- 
> 2.17.1
>