linux-kernel - Re: [PATCH] perf stat: Align the output for interval aggregation mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Mar 2020 16:00:49 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Jin Yao <yao.jin@...ux.intel.com>, jolsa@...nel.org,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH] perf stat: Align the output for interval aggregation mode

Em Thu, Feb 20, 2020 at 11:53:55AM +0100, Jiri Olsa escreveu:
> On Tue, Feb 18, 2020 at 03:16:14PM +0800, Jin Yao wrote:
> > There is a slight misalignment in -A -I output.
> > 
> > For example,
> > 
> >  perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> > 
> >  #           time CPU                    counts unit events
> >       1.000440863 CPU0               1,068,388      cpu/event=cpu-cycles/
> >       1.000440863 CPU1                 875,954      cpu/event=cpu-cycles/
> >       1.000440863 CPU2               3,072,538      cpu/event=cpu-cycles/
> >       1.000440863 CPU3               4,026,870      cpu/event=cpu-cycles/
> >       1.000440863 CPU4               5,919,630      cpu/event=cpu-cycles/
> >       1.000440863 CPU5               2,714,260      cpu/event=cpu-cycles/
> >       1.000440863 CPU6               2,219,240      cpu/event=cpu-cycles/
> >       1.000440863 CPU7               1,299,232      cpu/event=cpu-cycles/
> > 
> > The value of counts is not aligned with the column "counts" and
> > the event name is not aligned with the column "events".
> > 
> > With this patch, the output is,
> > 
> >  perf stat -e cpu/event=cpu-cycles/ -a -A -I 1000
> > 
> >  #           time CPU                    counts unit events
> >       1.000423009 CPU0                  997,421      cpu/event=cpu-cycles/
> >       1.000423009 CPU1                1,422,042      cpu/event=cpu-cycles/
> >       1.000423009 CPU2                  484,651      cpu/event=cpu-cycles/
> >       1.000423009 CPU3                  525,791      cpu/event=cpu-cycles/
> >       1.000423009 CPU4                1,370,100      cpu/event=cpu-cycles/
> >       1.000423009 CPU5                  442,072      cpu/event=cpu-cycles/
> >       1.000423009 CPU6                  205,643      cpu/event=cpu-cycles/
> >       1.000423009 CPU7                1,302,250      cpu/event=cpu-cycles/
> > 
> > Now output is aligned.
> > 
> > Signed-off-by: Jin Yao <yao.jin@...ux.intel.com>
> 
> Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks, tested and applied.

- Arnaldo