linux-kernel - Re: [PATCH] mmc: core: Fix indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Feb 2020 06:36:56 -0800
From:   Joe Perches <joe@...ches.com>
To:     Jerome Pouiller <Jerome.Pouiller@...abs.com>,
        linux-mmc@...r.kernel.org, Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: core: Fix indentation

On Fri, 2020-02-21 at 11:43 +0100, Jerome Pouiller wrote:
> sdio_single_irq_set() was indented with a mix of tabs and spaces.
[]
> diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c
[]
> @@ -278,12 +278,12 @@ static void sdio_single_irq_set(struct mmc_card *card)
>  	if ((card->host->caps & MMC_CAP_SDIO_IRQ) &&
>  	    card->host->sdio_irqs == 1)
>  		for (i = 0; i < card->sdio_funcs; i++) {
> -		       func = card->sdio_func[i];
> -		       if (func && func->irq_handler) {
> -			       card->sdio_single_irq = func;
> -			       break;
> -		       }
> -	       }
> +			func = card->sdio_func[i];
> +			if (func && func->irq_handler) {
> +				card->sdio_single_irq = func;
> +				break;
> +			}
> +		}
>  }

Perhaps it'd be better to add braces around the for loop too.
---
 drivers/mmc/core/sdio_irq.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/mmc/core/sdio_irq.c b/drivers/mmc/core/sdio_irq.c
index 7ca7b9..3086ed 100644
--- a/drivers/mmc/core/sdio_irq.c
+++ b/drivers/mmc/core/sdio_irq.c
@@ -260,14 +260,15 @@ static void sdio_single_irq_set(struct mmc_card *card)
 
 	card->sdio_single_irq = NULL;
 	if ((card->host->caps & MMC_CAP_SDIO_IRQ) &&
-	    card->host->sdio_irqs == 1)
+	    card->host->sdio_irqs == 1) {
 		for (i = 0; i < card->sdio_funcs; i++) {
-		       func = card->sdio_func[i];
-		       if (func && func->irq_handler) {
-			       card->sdio_single_irq = func;
-			       break;
-		       }
-	       }
+			func = card->sdio_func[i];
+			if (func && func->irq_handler) {
+				card->sdio_single_irq = func;
+				break;
+			}
+		}
+	}
 }
 
 /**