linux-kernel - Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal

Open Source and information security mailing list archives

Date:   Fri, 21 Feb 2020 15:39:32 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Torsten Duwe <duwe@....de>, Vasily Khoruzhick <anarsoul@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Thierry Reding <treding@...dia.com>
Cc:     Jernej Skrabec <jernej.skrabec@...l.net>,
        Jonas Karlman <jonas@...boo.se>,
        David Airlie <airlied@...ux.ie>,
        Neil Armstrong <narmstrong@...libre.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Andrzej Hajda <a.hajda@...sung.com>,
        Sean Paul <seanpaul@...omium.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Maxime Ripard <maxime@...no.tech>
Subject: Re: [RESEND2][PATCH] drm/bridge: analogix-anx6345: Fix drm_dp_link
 helper removal

Hi Torsten

Am 21.02.20 um 15:04 schrieb Torsten Duwe:
> drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
> and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
> and the multiply+divide alltogether.
> 
> fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")

You have to create the fixes tag and related cc tags with 'dim fixes',
available at [1]. For this patch, the output is

Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5")
Cc: Torsten Duwe <duwe@...e.de>
Cc: Maxime Ripard <maxime@...no.tech>
Cc: Torsten Duwe <duwe@....de>
Cc: Sam Ravnborg <sam@...nborg.org>
Cc: Linus Walleij <linus.walleij@...aro.org>
Cc: Thomas Zimmermann <tzimmermann@...e.de>
Cc: Icenowy Zheng <icenowy@...c.io>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>

> Signed-off-by: Torsten Duwe <duwe@...e.de>

You signed off with your SUSE email address, but sent the mail from
lst.de. I don't know if it's strictly not allowed, but that's at least
confusing to the tools.

Best regards
Thomas

[1] https://gitlab.freedesktop.org/drm/maintainer-tools/

> ---
> https://patchwork.freedesktop.org/patch/343004/
> https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html
> 
> Can someone please review this? It's equivalent to commit
> 3e138a63d6674a4567a018a31 which just made it into drm-tip.
> 
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -210,10 +210,9 @@ static int anx6345_dp_link_training(struct anx6345 *anx6345)
>  	if (err)
>  		return err;
>  
> -	dpcd[0] = drm_dp_max_link_rate(anx6345->dpcd);
> -	dpcd[0] = drm_dp_link_rate_to_bw_code(dpcd[0]);
>  	err = regmap_write(anx6345->map[I2C_IDX_DPTX],
> -			   SP_DP_MAIN_LINK_BW_SET_REG, dpcd[0]);
> +			   SP_DP_MAIN_LINK_BW_SET_REG,
> +			   anx6345->dpcd[DP_MAX_LINK_RATE]);
>  	if (err)
>  		return err;
>  
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives