linux-kernel - Re: [PATCH v4] leds: add SGI IP30 led support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49524a9a-910a-9f1a-bc10-d78080a16d46@gmail.com>
Date:   Fri, 21 Feb 2020 21:31:04 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Thomas Bogendoerfer <tbogendoerfer@...e.de>,
        Pavel Machek <pavel@....cz>
Cc:     Dan Murphy <dmurphy@...com>, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v4] leds: add SGI IP30 led support

Hi Thomas,

I have one nit below.

On 2/21/20 12:11 PM, Thomas Bogendoerfer wrote:
> This patch implemenets a driver to support the front panel LEDs of
> SGI Octane (IP30) workstations.
> 
> Reviewed-by: Dan Murphy <dmurphy@...com>
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> ---
> Changes in v4:
>   - simplified ip30led_set by using gated value from led framework
> 
> Changes in v3:
>   - rebased to 5.6-rc2
> 
> Changes in v2:
>   - use led names conforming to include/dt-bindings/leds/common.h
>   - read LED state from firmware
>   - leave setting up to user
> 
>  drivers/leds/Kconfig     | 11 ++++++
>  drivers/leds/Makefile    |  1 +
>  drivers/leds/leds-ip30.c | 77 ++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 89 insertions(+)
>  create mode 100644 drivers/leds/leds-ip30.c
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
[...]
> +	data->reg = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(data->reg))
> +		return PTR_ERR(data->reg);
> +
> +
> +	if (num == 0)
> +		data->cdev.name = "white:indicator";
> +	else
> +		data->cdev.name = "red:indicator";

Why indicator? Whereas it sounds quite generic it is used in the LED
subsystem specifically for naming indicator LEDs, that are often
found on flash LED controllers and are designed to indicate camera
sensor activity.

If it is on the front panel of SGI Octane workstations then its
function is perhaps well known?

-- 
Best regards,
Jacek Anaszewski