linux-kernel - Re: [PATCH v4] leds: add SGI IP30 led support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200222110545.fc96683543cb0dd538e5be82@suse.de>
Date:   Sat, 22 Feb 2020 11:05:45 +0100
From:   Thomas Bogendoerfer <tbogendoerfer@...e.de>
To:     Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:     Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v4] leds: add SGI IP30 led support

On Fri, 21 Feb 2020 21:31:04 +0100
Jacek Anaszewski <jacek.anaszewski@...il.com> wrote:


> > +	if (num == 0)
> > +		data->cdev.name = "white:indicator";
> > +	else
> > +		data->cdev.name = "red:indicator";
> 
> Why indicator? Whereas it sounds quite generic it is used in the LED
> subsystem specifically for naming indicator LEDs, that are often
> found on flash LED controllers and are designed to indicate camera
> sensor activity.

ok, ic.

> If it is on the front panel of SGI Octane workstations then its
> function is perhaps well known?

the red LED is clearly a fault led. The white LED will be switch on
after system diagnostic was successfull. Nothing from common.h really
fits that, maybe status ?

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer