linux-kernel - Re: [PATCH 4.19 188/191] cifs: log warning message (once) if out of disk space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200222162208.GA26320@sasha-vm>
Date:   Sat, 22 Feb 2020 11:22:08 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Steve French <stfrench@...rosoft.com>,
        Oleg Kravtsov <oleg@...era.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Pavel Shilovsky <pshilov@...rosoft.com>
Subject: Re: [PATCH 4.19 188/191] cifs: log warning message (once) if out of
 disk space

On Sat, Feb 22, 2020 at 01:59:31PM +0100, Pavel Machek wrote:
>On Fri 2020-02-21 08:42:41, Greg Kroah-Hartman wrote:
>> From: Steve French <stfrench@...rosoft.com>
>>
>> [ Upstream commit d6fd41905ec577851734623fb905b1763801f5ef ]
>>
>> We ran into a confusing problem where an application wasn't checking
>> return code on close and so user didn't realize that the application
>> ran out of disk space.  log a warning message (once) in these
>> cases. For example:
>>
>>   [ 8407.391909] Out of space writing to \\oleg-server\small-share
>
>Out of space can happen on any filesystem, and yes, it can be
>confusing. But why is cifs so special that we warn here (and not

cifs isn't special, we tend to take this type of patches that address
usability issues. Here's an example of a similar patch for btrfs from
the previous release (3 days ago):

https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.5.y&id=eb7a7968c9ee183def1d727d4bb209c701fe402a
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.5.y&id=f7447ff1d58a590e4b04479d1209fcee253a96d7

>elsewhere) and why was this marked for stable?

Reading the patch description, it describes a bug that happened because
of lacking kernel feedback.

-- 
Thanks,
Sasha