linux-kernel - Re: [PATCH] crypto: sm3 - export crypto_sm3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Feb 2020 12:19:26 +1100
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
Cc:     davem@...emloft.net, ebiggers@...nel.org, pvanleeuwen@...bus.com,
        zohar@...ux.ibm.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: sm3 - export crypto_sm3_final function

On Sun, Feb 16, 2020 at 05:02:33PM +0800, Tianjia Zhang wrote:
> Both crypto_sm3_update and crypto_sm3_finup have been
> exported, exporting crypto_sm3_final, to avoid having to
> use crypto_sm3_finup(desc, NULL, 0, dgst) to calculate
> the hash in some cases.
> 
> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
> ---
>  crypto/sm3_generic.c | 7 ++++---
>  include/crypto/sm3.h | 2 ++
>  2 files changed, 6 insertions(+), 3 deletions(-)

Please add this into the series that actually uses the function.
It makes no sense on its own.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt