linux-kernel - Re: [PATCH] crypto: sm3 - export crypto_sm3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8acc79e8-8b3d-856d-06d2-5322c9a66be9@linux.alibaba.com>
Date:   Sun, 23 Feb 2020 12:21:25 +0800
From:   Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     davem@...emloft.net, ebiggers@...nel.org, pvanleeuwen@...bus.com,
        zohar@...ux.ibm.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, gilad@...yossef.com
Subject: Re: [PATCH] crypto: sm3 - export crypto_sm3_final function



On 2020/2/22 9:19, Herbert Xu wrote:
> On Sun, Feb 16, 2020 at 05:02:33PM +0800, Tianjia Zhang wrote:
>> Both crypto_sm3_update and crypto_sm3_finup have been
>> exported, exporting crypto_sm3_final, to avoid having to
>> use crypto_sm3_finup(desc, NULL, 0, dgst) to calculate
>> the hash in some cases.
>>
>> Signed-off-by: Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>
>> ---
>>   crypto/sm3_generic.c | 7 ++++---
>>   include/crypto/sm3.h | 2 ++
>>   2 files changed, 6 insertions(+), 3 deletions(-)
> 
> Please add this into the series that actually uses the function.
> It makes no sense on its own.
> 
> Thanks,
> 

The actual use of this function is in sm2 and OSCCA certificates. This 
set of patches has been submitted to the community. Please review them.