linux-kernel - Re: [PATCH v3] partitions/efi: Fix partition name parsing in GUID partition entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Feb 2020 09:08:13 -0800
From:   hch <hch@...radead.org>
To:     Nikolai Merinov <n.merinov@...ngo-systems.com>
Cc:     hch <hch@...radead.org>, Davidlohr Bueso <dave@...olabs.net>,
        Jens Axboe <axboe@...nel.dk>, Ard Biesheuvel <ardb@...nel.org>,
        linux-efi <linux-efi@...r.kernel.org>,
        linux-block <linux-block@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] partitions/efi: Fix partition name parsing in GUID
 partition entry

On Mon, Feb 24, 2020 at 01:38:39PM +0200, Nikolai Merinov wrote:
> Hi Christoph, 
> 
> > I'd rather use plain __le16 and le16_to_cpu here. Also the be 
> > variants seems to be entirely unused. 
> 
> Looks like I misunderstood your comment from https://patchwork.kernel.org/patch/11309223/: 
> 
> > Please add a an efi_char_from_cpu or similarly named helper 
> > to encapsulate this logic. 
> 
> The "le16_to_cpu(ptes[i].partition_name[label_count])" call is the 
> full implementation of the "efi_char_from_cpu" logic. Do you want 
> to encapsulate "utf16_le_to_7bit_string" logic entirely like in
> the attached version?

I think I though of just the inner loop, but your new version looks even
better, so:

Reviewed-by: Christoph Hellwig <hch@....de>