linux-kernel - Re: [PATCH] staging: wfx: match parentheses alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1761697.Ie2Hvvaxtr@pc-42>
Date:   Mon, 24 Feb 2020 09:22:36 +0000
From:   Jérôme Pouiller <Jerome.Pouiller@...abs.com>
To:     Kaaira Gupta <kgupta@...iitr.ac.in>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: wfx: match parentheses alignment

On Sunday 23 February 2020 20:32:01 CET Kaaira Gupta wrote:
> 
> match next line with open parentheses by giving appropriate tabs.

Maybe the body of the commit message should start with a capital letter,
else:

Reviewed-by: Jérôme Pouiller <jerome.pouiller@...abs.com>

> 
> Signed-off-by: Kaaira Gupta <kgupta@...iitr.ac.in>
> ---
>  drivers/staging/wfx/data_tx.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c
> index 20f4740734f2..815fde0913f5 100644
> --- a/drivers/staging/wfx/data_tx.c
> +++ b/drivers/staging/wfx/data_tx.c
> @@ -300,8 +300,8 @@ static void wfx_tx_manage_pm(struct wfx_vif *wvif, struct ieee80211_hdr *hdr,
>  }
> 
>  static u8 wfx_tx_get_raw_link_id(struct wfx_vif *wvif,
> -                                     struct ieee80211_sta *sta,
> -                                     struct ieee80211_hdr *hdr)
> +                                struct ieee80211_sta *sta,
> +                                struct ieee80211_hdr *hdr)
>  {
>         struct wfx_sta_priv *sta_priv =
>                 sta ? (struct wfx_sta_priv *) &sta->drv_priv : NULL;
> @@ -368,7 +368,7 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates)
>  }
> 
>  static u8 wfx_tx_get_rate_id(struct wfx_vif *wvif,
> -                                 struct ieee80211_tx_info *tx_info)
> +                            struct ieee80211_tx_info *tx_info)
>  {
>         bool tx_policy_renew = false;
>         u8 rate_id;


-- 
Jérôme Pouiller