linux-kernel - RE: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB8PR04MB67474FF5451A647C4495526F84EC0@DB8PR04MB6747.eurprd04.prod.outlook.com>
Date:   Mon, 24 Feb 2020 09:22:47 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     Michael Walle <michael@...le.cc>, Shawn Guo <shawnguo@...nel.org>
CC:     Xiaowei Bao <xiaowei.bao@....com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Leo Li <leoyang.li@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "M.h. Lian" <minghuan.lian@....com>,
        Mingkai Hu <mingkai.hu@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        Roy Zang <roy.zang@....com>
Subject: RE: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes

Hi Michael and Shawn,

I'll update the patch with iommu-map property.

Thanks,
Zhiqiang

> -----Original Message-----
> From: Michael Walle <michael@...le.cc>
> Sent: 2020年2月24日 16:54
> To: Shawn Guo <shawnguo@...nel.org>
> Cc: Xiaowei Bao <xiaowei.bao@....com>; Z.q. Hou
> <zhiqiang.hou@....com>; bhelgaas@...gle.com;
> devicetree@...r.kernel.org; Leo Li <leoyang.li@....com>;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> linux-pci@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org;
> lorenzo.pieralisi@....com; mark.rutland@....com; M.h. Lian
> <minghuan.lian@....com>; Mingkai Hu <mingkai.hu@....com>;
> robh+dt@...nel.org; Roy Zang <roy.zang@....com>
> Subject: Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT
> nodes
> 
> Hi Shawn, all,
> 
> Am 2020-02-24 09:43, schrieb Shawn Guo:
> > On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote:
> >> Hi Xiaowei, Hi Shawn,
> >>
> >> > LS1028a implements 2 PCIe 3.0 controllers.
> >>
> >> Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about
> >> this patch anymore :(
> >>
> >> This doesn't work well with the IOMMU, because the iommu-map property
> >> is missing. The bootloader needs the &smmu phandle to fixup the
> >> entry.
> >> See
> >> below.
> >>
> >> Shawn, will you add this patch to your tree once its fixed,
> >> considering it just adds the device tree node for the LS1028A?
> >
> > The patch/thread is a bit aged.  You may want to send an updated patch
> > for discussion.
> 
> So should I just pick up the patch add my two fixes and send it again?
> What about
> the Signed-off-by tags? Leave them? Replace them? Add mine?
> 
> -michael