linux-kernel - Re: [PATCH] f2fs: use kmem_cache pool during inline xattr lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Feb 2020 16:21:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>
Cc:     kbuild-all@...ts.01.org, jaegeuk@...nel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, chao@...nel.org,
        Chao Yu <yuchao0@...wei.com>,
        Park Ju Hyung <qkrwngud825@...il.com>
Subject: Re: [PATCH] f2fs: use kmem_cache pool during inline xattr lookups

Hi Chao,

I love your patch! Perhaps something to improve:

[auto build test WARNING on f2fs/dev-test]
[cannot apply to v5.6-rc3 next-20200224]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Chao-Yu/f2fs-use-kmem_cache-pool-during-inline-xattr-lookups/20200225-094422
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
config: x86_64-randconfig-s2-20200225 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from fs/f2fs/dir.c:15:0:
   fs/f2fs/xattr.h: In function 'f2fs_destroy_xattr_caches':
>> fs/f2fs/xattr.h:157:74: warning: 'return' with a value, in function returning void
    static void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
                                                                             ^
   fs/f2fs/xattr.h:157:13: note: declared here
    static void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
                ^~~~~~~~~~~~~~~~~~~~~~~~~
   At top level:
   fs/f2fs/xattr.h:157:13: warning: 'f2fs_destroy_xattr_caches' defined but not used [-Wunused-function]
   fs/f2fs/xattr.h:156:12: warning: 'f2fs_init_xattr_caches' defined but not used [-Wunused-function]
    static int f2fs_init_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
               ^~~~~~~~~~~~~~~~~~~~~~
--
   In file included from fs/f2fs/super.c:31:0:
   fs/f2fs/xattr.h: In function 'f2fs_destroy_xattr_caches':
>> fs/f2fs/xattr.h:157:74: warning: 'return' with a value, in function returning void
    static void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
                                                                             ^
   fs/f2fs/xattr.h:157:13: note: declared here
    static void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
                ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/return +157 fs/f2fs/xattr.h

   137	
   138	#define f2fs_xattr_handlers	NULL
   139	static inline int f2fs_setxattr(struct inode *inode, int index,
   140			const char *name, const void *value, size_t size,
   141			struct page *page, int flags)
   142	{
   143		return -EOPNOTSUPP;
   144	}
   145	static inline int f2fs_getxattr(struct inode *inode, int index,
   146				const char *name, void *buffer,
   147				size_t buffer_size, struct page *dpage)
   148	{
   149		return -EOPNOTSUPP;
   150	}
   151	static inline ssize_t f2fs_listxattr(struct dentry *dentry, char *buffer,
   152			size_t buffer_size)
   153	{
   154		return -EOPNOTSUPP;
   155	}
   156	static int f2fs_init_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
 > 157	static void f2fs_destroy_xattr_caches(struct f2fs_sb_info *sbi) { return 0; }
   158	#endif
   159	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (38836 bytes)