linux-kernel - Re: [PATCH v1 3/3] nvmem: Remove .read_only field from nvmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PSXP216MB043889D5ADEC4E9BF36CC3E080ED0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
Date:   Tue, 25 Feb 2020 10:49:33 +0000
From:   Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH v1 3/3] nvmem: Remove .read_only field from nvmem_config

On Mon, Feb 24, 2020 at 05:43:29PM +0000, Nicholas Johnson wrote:
> There is no .write_only field in nvmem_config, so having .read_only
> makes no sense. We can determine the attrs based on whether .reg_read
> and .reg_write are provided. Using only .reg_read and .reg_write means
> that there can no longer be contradictions (for instance, if .read_only
> is set but .reg_read is NULL).
> 
> Remove .read_only field from nvmem_config.
> 
> Remove all references to .read_only field from drivers.
> 
> Update drivers to only supply nvmem->reg_write if write attrs are
> desired.
> 
> Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
> ---

Sorry all, I got this build bot [0] telling me that this patch 3/3 fails 
to compile for ARM architecture. It worked for x86-64. So please ignore 
3/3 for now while I investigate. 1/3 and 2/3 are all good.

I will find a better way to ensure that I have all of the references and 
post a PATCH v2 sometime.

Kind regards,
Nicholas

[0]
https://lore.kernel.org/lkml/202002250920.gc0wDekv%25lkp@intel.com/