linux-kernel - Re: [PATCH] selftests/timers: Turn off timeout setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbc88e24-835b-2b1e-2997-255896b14cc4@kernel.org>
Date:   Tue, 25 Feb 2020 08:30:41 -0700
From:   shuah <shuah@...nel.org>
To:     Po-Hsu Lin <po-hsu.lin@...onical.com>,
        linux-kselftest@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, sboyd@...nel.org, tglx@...utronix.de,
        john.stultz@...aro.org, shuah <shuah@...nel.org>
Subject: Re: [PATCH] selftests/timers: Turn off timeout setting

On 2/25/20 3:18 AM, Po-Hsu Lin wrote:
> Tests in timers especially nsleep-lat, set-timer-lat,
> inconsistency-check and raw_skew these 4 tests can take longer than
> the default 45 seconds that introduced in commit 852c8cbf
> (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
> 
> Disable the timeout setting for timers instead of looking for an proper
> value to make it more general.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@...onical.com>
> ---
>   tools/testing/selftests/timers/settings | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 100644 tools/testing/selftests/timers/settings
> 
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
> 

What happens when you disable this and set it to 0? How long does the
rest run in this case? Can you add the details to the change log please.

thanks,
-- Shuah