[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200225175735.GA5232@bogus>
Date: Tue, 25 Feb 2020 11:57:35 -0600
From: Rob Herring <robh@...nel.org>
To: Joakim Zhang <qiangqing.zhang@....com>
Cc: mturquette@...libre.com, sboyd@...nel.org, mark.rutland@....com,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-imx@....com, Anson.Huang@....com,
leonard.crestez@....com, daniel.baluta@....com,
aisheng.dong@....com, peng.fan@....com, fugang.duan@....com,
linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] clk: imx8: Add SCU and LPCG clocks for I2C in CM40 SS
On Mon, Feb 17, 2020 at 11:19:16AM +0800, Joakim Zhang wrote:
> Add SCU and LPCG clocks for I2C in CM40 SS.
>
> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> ---
> include/dt-bindings/clock/imx8-clock.h | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/imx8-clock.h b/include/dt-bindings/clock/imx8-clock.h
> index 673a8c662340..84a442be700f 100644
> --- a/include/dt-bindings/clock/imx8-clock.h
> +++ b/include/dt-bindings/clock/imx8-clock.h
> @@ -131,7 +131,12 @@
> #define IMX_ADMA_PWM_CLK 188
> #define IMX_ADMA_LCD_CLK 189
>
> -#define IMX_SCU_CLK_END 190
> +/* CM40 SS */
> +#define IMX_CM40_IPG_CLK 200
> +#define IMX_CM40_I2C_CLK 205
> +
> +#define IMX_SCU_CLK_END 220
Why are you skipping numbers?
> +
>
> /* LPCG clocks */
>
> @@ -290,4 +295,10 @@
>
> #define IMX_ADMA_LPCG_CLK_END 45
>
> +/* CM40 SS LPCG */
> +#define IMX_CM40_LPCG_I2C_IPG_CLK 0
> +#define IMX_CM40_LPCG_I2C_CLK 1
> +
> +#define IMX_CM40_LPCG_CLK_END 2
> +
> #endif /* __DT_BINDINGS_CLOCK_IMX_H */
> --
> 2.17.1
>
Powered by blists - more mailing lists