linux-kernel - Re: [for-next PATCH 1/5] phy: ti: gmii-sel: simplify config dependencies between net drivers and gmii phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <78f6521a-d44b-b0b9-8dcf-4b1dc1446946@ti.com>
Date:   Tue, 25 Feb 2020 13:04:34 -0500
From:   Murali Karicheri <m-karicheri2@...com>
To:     Grygorii Strashko <grygorii.strashko@...com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Tero Kristo <t-kristo@...com>,
        "David S. Miller" <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, Sekhar Nori <nsekhar@...com>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [for-next PATCH 1/5] phy: ti: gmii-sel: simplify config
 dependencies between net drivers and gmii phy

Hi Grygorii,

On 02/22/2020 07:03 AM, Grygorii Strashko wrote:
> The phy-gmii-sel can be only autoselacted in Kconfig and now the pretty
s/autoselacted/auto selected
> complex Kconfig dependencies are defined for phy-gmii-sel driver, which
> also need to be updated every time phy-gmii-sel is re-used for any new
> networking driver.
> 
> Simplify Kconfig definotion for phy-gmii-sel PHY driver - drop all

s/definotion/definition

> depndencies and from networking drivers and rely on using 'imply imply

s/depndencies/dependencies

> PHY_TI_GMII_SEL' in Kconfig definotions for networking drivers instead.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
> ---
>   drivers/net/ethernet/ti/Kconfig | 1 +
>   drivers/phy/ti/Kconfig          | 3 ---
>   2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
> index bf98e0fa7d8b..8a6ca16eee3b 100644
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -53,6 +53,7 @@ config TI_CPSW
>   	select MFD_SYSCON
>   	select PAGE_POOL
>   	select REGMAP
> +	imply PHY_TI_GMII_SEL
>   	---help---
>   	  This driver supports TI's CPSW Ethernet Switch.
>   
> diff --git a/drivers/phy/ti/Kconfig b/drivers/phy/ti/Kconfig
> index 6dbe9d0b9ff3..15a3bcf32308 100644
> --- a/drivers/phy/ti/Kconfig
> +++ b/drivers/phy/ti/Kconfig
> @@ -106,11 +106,8 @@ config TWL4030_USB
>   
>   config PHY_TI_GMII_SEL
>   	tristate
> -	default y if TI_CPSW=y || TI_CPSW_SWITCHDEV=y
> -	depends on TI_CPSW || TI_CPSW_SWITCHDEV || COMPILE_TEST
>   	select GENERIC_PHY
>   	select REGMAP
> -	default m
>   	help
>   	  This driver supports configuring of the TI CPSW Port mode depending on
>   	  the Ethernet PHY connected to the CPSW Port.
> 

-- 
Murali Karicheri
Texas Instruments