lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 25 Feb 2020 10:28:25 -0800 From: Krish Sadhukhan <krish.sadhukhan@...cle.com> To: Vitaly Kuznetsov <vkuznets@...hat.com>, Xiaoyao Li <xiaoyao.li@...el.com> Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>, Sean Christopherson <sean.j.christopherson@...el.com>, Wanpeng Li <wanpengli@...cent.com>, Jim Mattson <jmattson@...gle.com>, Joerg Roedel <joro@...tes.org> Subject: Re: [PATCH 1/2] kvm: vmx: Use basic exit reason to check if it's the specific VM EXIT On 2/25/20 5:11 AM, Vitaly Kuznetsov wrote: > Krish Sadhukhan <krish.sadhukhan@...cle.com> writes: > >> We have a macro for bit 31, >> >> VMX_EXIT_REASONS_FAILED_VMENTRY 0x80000000 >> >> >> Does it make sense to define a macro like that instead ? Say, >> >> VMX_BASIC_EXIT_REASON 0x0000ffff >> > 0xffffU ? > >> and then we do, >> >> u32 exit_reason = vmx->exit_reason; >> u16 basic_exit_reason = exit_reason & VMX_BASIC_EXIT_REASON; >> > Just a naming suggestion: if we decide to go down this road, let's name > it e.g. VMX_BASIC_EXIT_REASON_MASK to make it clear this is *not* an > exit reason. > VMX_BASIC_EXIT_REASON_MASK works.
Powered by blists - more mailing lists