linux-kernel - Re: [patch 05/15] x86/entry: Provide IDTEnTRY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h7zdp0kv.fsf@nanos.tec.linutronix.de>
Date:   Wed, 26 Feb 2020 21:15:12 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Andy Lutomirski <luto@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, Steven Rostedt <rostedt@...dmis.org>,
        Brian Gerst <brgerst@...il.com>,
        Juergen Gross <jgross@...e.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [patch 05/15] x86/entry: Provide IDTEnTRY_SYSVEC

Andy Lutomirski <luto@...nel.org> writes:

> On 2/25/20 2:47 PM, Thomas Gleixner wrote:
>> Provide a IDTENTRY variant for system vectors to consolidate the differnt
>> mechanisms to emit the ASM stubs for 32 an 64 bit.
>
> $SUBJECT has an obvious typo.

Indeed.

>> --- a/arch/x86/entry/entry_32.S
>> +++ b/arch/x86/entry/entry_32.S
>> @@ -1261,6 +1261,10 @@ SYM_CODE_START_LOCAL(asm_\cfunc)
>>  SYM_CODE_END(asm_\cfunc)
>>  .endm
>>  
>> +.macro idtentry_sysvec vector cfunc
>> +	idtentry \vector asm_\cfunc \cfunc has_error_code=0
>> +.endm
>
> irq_stack?

System vectors have never used irq stacks.

Thanks,

        tglx