linux-kernel - Re: [patch 16/16] x86/entry: Disable interrupts in IDTENTRY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200226092335.GS18400@hirez.programming.kicks-ass.net>
Date:   Wed, 26 Feb 2020 10:23:35 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        Steven Rostedt <rostedt@...dmis.org>,
        Brian Gerst <brgerst@...il.com>,
        Juergen Gross <jgross@...e.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [patch 16/16] x86/entry: Disable interrupts in IDTENTRY

On Tue, Feb 25, 2020 at 11:33:37PM +0100, Thomas Gleixner wrote:
> Not all exceptions guarantee to return with interrupts disabled. Disable
> them in idtentry_exit() which is invoked on all regular (non IST) exception
> entry points. Preparatory patch for further consolidation of the return
> code.

ISTR a patch that undoes cond_local_irq_enable() in the various trap
handlers. Did that get lost or is that still on the TODO list somewhere?

Once we do that, this can turn into an assertion that IRQs are in fact
disabled.