linux-kernel - Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKVNENPZKbCy4FrGRO=D79hBL3keuE-U2tTwDVViCrdPQ@mail.gmail.com>
Date:   Wed, 26 Feb 2020 08:33:53 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sharat Masetty <smasetty@...eaurora.org>
Cc:     freedreno <freedreno@...ts.freedesktop.org>,
        devicetree@...r.kernel.org, Doug Anderson <dianders@...omium.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Matthias Kaehlcke <mka@...omium.org>, dri-devel@...edesktop.org
Subject: Re: [PATCH] dt-bindings: arm-smmu: update the list of clocks

On Wed, Feb 26, 2020 at 5:17 AM Sharat Masetty <smasetty@...eaurora.org> wrote:
>
>
> On 2/21/2020 2:05 AM, Rob Herring wrote:
> > On Thu, 20 Feb 2020 13:42:22 +0530, Sharat Masetty wrote:
> >> This patch adds a clock definition needed for powering on the GPU TBUs
> >> and the GPU TCU.
> >>
> >> Signed-off-by: Sharat Masetty <smasetty@...eaurora.org>
> >> ---
> >>   Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 +++
> >>   1 file changed, 3 insertions(+)
> >>
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@...000: clock-names: ['bus', 'iface'] is too short
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iommu/arm,smmu.example.dt.yaml: iommu@...000: clocks: [[4294967295, 123], [4294967295, 124]] is too short
> >
> > See https://patchwork.ozlabs.org/patch/1241297
> > Please check and re-submit.
> Hi Rob, These issues seem to be from the original code and not related
> to my patch. Are these going to be blocking errors?

There are no errors in this binding in mainline. You've added a 3rd
clock when all the existing users have exactly 2 clocks.

Rob