linux-kernel - Re: [PATCH bpf-next v3 2/5] bpftool: Make probes which emit dmesg warnings optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9398747e-2ebe-074b-afea-3d0ba7555479@iogearbox.net>
Date:   Wed, 26 Feb 2020 16:35:18 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Michal Rostecki <mrostecki@...nsuse.org>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>,
        Quentin Monnet <quentin.monnet@...ronome.com>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf-next v3 2/5] bpftool: Make probes which emit dmesg
 warnings optional

On 2/25/20 8:44 PM, Michal Rostecki wrote:
> Probes related to bpf_probe_write_user and bpf_trace_printk helpers emit
> dmesg warnings which might be confusing for people running bpftool on
> production environments. This change filters them out by default and
> introduces the new positional argument "full" which enables all
> available probes.
> 
> Signed-off-by: Michal Rostecki <mrostecki@...nsuse.org>
[...]
> +		/* Skip helper functions which emit dmesg messages when not in
> +		 * the full mode.
> +		 */
> +		switch (id) {
> +		case 6: /* trace_printk */
> +		case 36: /* probe_write_user */

Please fix this into the actual enum above, then also the comment is not needed.

> +			if (!full_mode)
> +				continue;
> +			/* fallthrough */
> +		default:
> +			probe_helper_for_progtype(prog_type, supported_type,
> +						  define_prefix, id, ptype_name,
> +						  ifindex);
>   		}
>   	}