[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200226172457.GA3267@bogus>
Date: Wed, 26 Feb 2020 11:24:57 -0600
From: Rob Herring <robh@...nel.org>
To: sherry sun <sherry.sun@....com>
Cc: bp@...en8.de, mchehab@...nel.org, tony.luck@...el.com,
james.morse@....com, rrichter@...vell.com, michal.simek@...inx.com,
shawnguo@...nel.org, s.hauer@...gutronix.de, mark.rutland@....com,
linux-edac@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-imx@....com, frank.li@....com
Subject: Re: [PATCH 1/3] dt-bindings: memory-controllers: Add i.MX8MP DDRC
binding doc
On Fri, Feb 21, 2020 at 02:39:14PM +0800, sherry sun wrote:
> From: Sherry Sun <sherry.sun@....com>
>
> Add documentation for i.MX8MP DDRC binding based on synopsys_edac doc,
> which use the same memory-controller IP.
>
> Signed-off-by: Sherry Sun <sherry.sun@....com>
> ---
> .../devicetree/bindings/memory-controllers/synopsys.txt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/synopsys.txt b/Documentation/devicetree/bindings/memory-controllers/synopsys.txt
> index 9d32762c47e1..5c03959a451f 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/synopsys.txt
> +++ b/Documentation/devicetree/bindings/memory-controllers/synopsys.txt
> @@ -6,16 +6,20 @@ bus width configurations.
> The Zynq DDR ECC controller has an optional ECC support in half-bus width
> (16-bit) configuration.
>
> -These both ECC controllers correct single bit ECC errors and detect double bit
> +The i.MX8MP DDR ECC controller has an ECC support in 64-bit bus width
> +configurations.
> +
> +These all ECC controllers correct single bit ECC errors and detect double bit
All the ECC...
With that,
Reviewed-by: Rob Herring <robh@...nel.org>
> ECC errors.
>
> Required properties:
> - compatible: One of:
> - 'xlnx,zynq-ddrc-a05' : Zynq DDR ECC controller
> - 'xlnx,zynqmp-ddrc-2.40a' : ZynqMP DDR ECC controller
> + - 'fsl,imx8mp-ddrc' : i.MX8MP DDR ECC controller
> - reg: Should contain DDR controller registers location and length.
>
> -Required properties for "xlnx,zynqmp-ddrc-2.40a":
> +Required properties for "xlnx,zynqmp-ddrc-2.40a" and "fsl,imx8mp-ddrc":
> - interrupts: Property with a value describing the interrupt number.
>
> Example:
> --
> 2.17.1
>
Powered by blists - more mailing lists