linux-kernel - Re: [PATCH] clocksource: timer-ti-dm: Drop bogus omap_dm_timer_of_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f32f784-94e9-3105-cabd-ebf4093cbbf6@linaro.org>
Date:   Wed, 26 Feb 2020 18:24:33 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Tony Lindgren <tony@...mide.com>, Suman Anna <s-anna@...com>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tero Kristo <t-kristo@...com>,
        Neil Armstrong <narmstrong@...libre.com>,
        "H . Nikolaus Schaller" <hns@...delico.com>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Keerthy <j-keerthy@...com>,
        Ladislav Michl <ladis@...ux-mips.org>,
        Pavel Machek <pavel@....cz>, Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH] clocksource: timer-ti-dm: Drop bogus
 omap_dm_timer_of_set_source()

On 26/02/2020 17:16, Tony Lindgren wrote:
> * Suman Anna <s-anna@...com> [200212 21:36]:
>> Hi Tony,
>>
>> Do you have the history of why the 32 KHz source is set as parent during
>> prepare? One of the current side-affects of this patch is that now instead
>> of bailing out, the 32 KHz source is set, and consumers will still need
>> to select their appropriate parent. Dropping that call should actually
>> allow us to select the parents in the consumer nodes in dts files using
>> the assigned-clocks and assigned-clock-parents properties. I prefer to
>> drop it if you do not foresee any issues. For now, I do not anticipate
>> any issues with omap-pwm-dmtimer with this patch.
> 
> Using the 32 KiHz source works better for PM. But yeah the
> machine specific source clock should be configured with
> assigned-clocks and assigned-clock-parents properites.
> 
> Things seem to behave just fine for me with this patch for both
> pwm-leds and PM. Good to see this function gone:
> 
> Tested-by: Tony Lindgren <tony@...mide.com>

Thanks for testing


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog