linux-kernel - Re: [PATCH 07/21] drm/arm: make hdlcd_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200227145320.GY364558@e110455-lin.cambridge.arm.com>
Date:   Thu, 27 Feb 2020 14:53:20 +0000
From:   Liviu Dudau <liviu.dudau@....com>
To:     Wambui Karuga <wambui.karugax@...il.com>
Cc:     daniel@...ll.ch, airlied@...ux.ie,
        Brian Starkey <brian.starkey@....com>,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 07/21] drm/arm: make hdlcd_debugfs_init() return void

On Thu, Feb 27, 2020 at 03:02:18PM +0300, Wambui Karuga wrote:
> Since commit 987d65d01356 (drm: debugfs: make
> drm_debugfs_create_files() never fail), drm_debugfs_create_files()
> never fails, and should return void. Therefore, remove its use as a
> return value in hdlcd_debugfs_init and have the latter function
> return void.
> 
> Signed-off-by: Wambui Karuga <wambui.karugax@...il.com>

Acked-by: Liviu Dudau <liviu.dudau@....com>

Not sure how you're going to address Greg KH's comment (maybe one single patch that
converts debugfs_init to void *and* changes the signature to all hooks?) but I'm
going to assume that you will get the whole series merged in one go so I don't have
to push this individual patch into HDLCD tree.

Best regards,
Liviu

> ---
>  drivers/gpu/drm/arm/hdlcd_drv.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index 2e053815b54a..194419f47c5e 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -224,10 +224,11 @@ static struct drm_info_list hdlcd_debugfs_list[] = {
>  	{ "clocks", hdlcd_show_pxlclock, 0 },
>  };
>  
> -static int hdlcd_debugfs_init(struct drm_minor *minor)
> +static void hdlcd_debugfs_init(struct drm_minor *minor)
>  {
> -	return drm_debugfs_create_files(hdlcd_debugfs_list,
> -		ARRAY_SIZE(hdlcd_debugfs_list),	minor->debugfs_root, minor);
> +	drm_debugfs_create_files(hdlcd_debugfs_list,
> +				 ARRAY_SIZE(hdlcd_debugfs_list),
> +				 minor->debugfs_root, minor);
>  }
>  #endif
>  
> -- 
> 2.25.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯