[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200227145351.GZ364558@e110455-lin.cambridge.arm.com>
Date: Thu, 27 Feb 2020 14:53:51 +0000
From: Liviu Dudau <liviu.dudau@....com>
To: Wambui Karuga <wambui.karugax@...il.com>
Cc: daniel@...ll.ch, airlied@...ux.ie,
Brian Starkey <brian.starkey@....com>,
linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 21/21] drm/arm: have malidp_debufs_init() return void
On Thu, Feb 27, 2020 at 03:02:32PM +0300, Wambui Karuga wrote:
> As there's no need for the return value in malidp_debugfs_init() after
> the conversion of the drm_driver.debugfs_init() hook, (drm: convert the
> .debugs_init() hook to return void), convert the malidp_debugfs_init()
> function to return void.
>
> Signed-off-by: Wambui Karuga <wambui.karugax@...il.com>
Acked-by: Liviu Dudau <liviu.dudau@....com>
Thanks!
Liviu
> ---
> drivers/gpu/drm/arm/malidp_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 37d92a06318e..def8c9ffafca 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -548,7 +548,7 @@ static const struct file_operations malidp_debugfs_fops = {
> .release = single_release,
> };
>
> -static int malidp_debugfs_init(struct drm_minor *minor)
> +static void malidp_debugfs_init(struct drm_minor *minor)
> {
> struct malidp_drm *malidp = minor->dev->dev_private;
>
> @@ -557,7 +557,6 @@ static int malidp_debugfs_init(struct drm_minor *minor)
> spin_lock_init(&malidp->errors_lock);
> debugfs_create_file("debug", S_IRUGO | S_IWUSR, minor->debugfs_root,
> minor->dev, &malidp_debugfs_fops);
> - return 0;
> }
>
> #endif //CONFIG_DEBUG_FS
> --
> 2.25.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
Powered by blists - more mailing lists