[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a965d97ddf99d4a335582732dfac7b0948258632.camel@pengutronix.de>
Date: Thu, 27 Feb 2020 14:36:40 +0100
From: Lucas Stach <l.stach@...gutronix.de>
To: Wambui Karuga <wambui.karugax@...il.com>, daniel@...ll.ch,
airlied@...ux.ie, Russell King <linux+etnaviv@...linux.org.uk>,
Christian Gmeiner <christian.gmeiner@...il.com>
Cc: linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 08/21] drm/etnaviv: remove check for return value of
drm_debugfs function
On Do, 2020-02-27 at 15:02 +0300, Wambui Karuga wrote:
> Since commit 987d65d01356 (drm: debugfs: make
> drm_debugfs_create_files() never fail), drm_debugfs_create_file only
> returns 0, and there is no need to check the return value.
> This change therefore removes the check and error handling in
> etnaviv_debugfs_init() and also makes the function return void.
>
> Signed-off-by: Wambui Karuga <wambui.karugax@...il.com>
Reviewed-by: Lucas Stach <l.stach@...gutronix.de>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_drv.c | 18 ++++--------------
> 1 file changed, 4 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> index 6b43c1c94e8f..a39735316ca5 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> @@ -231,21 +231,11 @@ static struct drm_info_list etnaviv_debugfs_list[] = {
> {"ring", show_each_gpu, 0, etnaviv_ring_show},
> };
>
> -static int etnaviv_debugfs_init(struct drm_minor *minor)
> +static void etnaviv_debugfs_init(struct drm_minor *minor)
> {
> - struct drm_device *dev = minor->dev;
> - int ret;
> -
> - ret = drm_debugfs_create_files(etnaviv_debugfs_list,
> - ARRAY_SIZE(etnaviv_debugfs_list),
> - minor->debugfs_root, minor);
> -
> - if (ret) {
> - dev_err(dev->dev, "could not install etnaviv_debugfs_list\n");
> - return ret;
> - }
> -
> - return ret;
> + drm_debugfs_create_files(etnaviv_debugfs_list,
> + ARRAY_SIZE(etnaviv_debugfs_list),
> + minor->debugfs_root, minor);
> }
> #endif
>
Powered by blists - more mailing lists