linux-kernel - Re: [PATCH v3 6/8] x86-32: Enable syscall wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzpN2j7hO6vpopjc8po+v-9u3mmQ5Z_ZefVai3pJeV823_7Uw@mail.gmail.com>
Date:   Fri, 28 Feb 2020 15:06:14 -0500
From:   Brian Gerst <brgerst@...il.com>
To:     Andy Lutomirski <luto@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, X86 ML <x86@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>
Subject: Re: [PATCH v3 6/8] x86-32: Enable syscall wrappers

On Fri, Feb 28, 2020 at 2:01 PM Andy Lutomirski <luto@...nel.org> wrote:
>
> On Thu, Feb 27, 2020 at 5:28 AM Brian Gerst <brgerst@...il.com> wrote:
> >
> > Enable pt_regs based syscalls for 32-bit.  This makes the 32-bit native
> > kernel consistent with the 64-bit kernel, and improves the syscall
> > interface by not needing to push all 6 potential arguments onto the stack.
>
> Was the change to the table mechanically generated or mechanically
> verified?  If so, how?

It was done by hand, but I can look into writing a script to verify it.

> After this goes in, I should dust off my code to get rid of all the
> __abi crud in the tables.  I never quite got it working well enough,
> but your series should help.

That would be nice.  After my patches, everything has the ABI prefix
to the functions.

--
Brian Gerst