linux-kernel - RE: [Intel-gfx] [RFC][PATCH 5/5] drm/i915/display: Add Nearest-neighbor based integer scaling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E92BA18FDE0A5B43B7B3DA7FCA03128605778A4D@BGSMSX107.gar.corp.intel.com>
Date:   Fri, 28 Feb 2020 05:50:16 +0000
From:   "Laxminarayan Bharadiya, Pankaj" 
        <pankaj.laxminarayan.bharadiya@...el.com>
To:     Daniel Stone <daniel@...ishbar.org>
CC:     Jani Nikula <jani.nikula@...ux.intel.com>,
        Daniel Vetter <daniel@...ll.ch>,
        intel-gfx <intel-gfx@...ts.freedesktop.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        Maxime Ripard <mripard@...nel.org>,
        "mihail.atanassov@....com" <mihail.atanassov@....com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@...el.com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        "Souza, Jose" <jose.souza@...el.com>,
        "De Marchi, Lucas" <lucas.demarchi@...el.com>,
        "Roper, Matthew D" <matthew.d.roper@...el.com>,
        "Deak, Imre" <imre.deak@...el.com>,
        "Shankar, Uma" <uma.shankar@...el.com>,
        "Nautiyal, Ankit K" <ankit.k.nautiyal@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-gfx] [RFC][PATCH 5/5] drm/i915/display: Add
 Nearest-neighbor based integer scaling support



> -----Original Message-----
> From: Daniel Stone <daniel@...ishbar.org>
> Sent: 25 February 2020 13:00
> To: Laxminarayan Bharadiya, Pankaj
> <pankaj.laxminarayan.bharadiya@...el.com>
> Cc: Jani Nikula <jani.nikula@...ux.intel.com>; Daniel Vetter
> <daniel@...ll.ch>; intel-gfx <intel-gfx@...ts.freedesktop.org>; dri-devel
> <dri-devel@...ts.freedesktop.org>; Ville Syrjälä
> <ville.syrjala@...ux.intel.com>; David Airlie <airlied@...ux.ie>; Maarten
> Lankhorst <maarten.lankhorst@...ux.intel.com>; tzimmermann@...e.de;
> Maxime Ripard <mripard@...nel.org>; mihail.atanassov@....com; Joonas
> Lahtinen <joonas.lahtinen@...ux.intel.com>; Vivi, Rodrigo
> <rodrigo.vivi@...el.com>; Chris Wilson <chris@...is-wilson.co.uk>; Souza,
> Jose <jose.souza@...el.com>; De Marchi, Lucas
> <lucas.demarchi@...el.com>; Roper, Matthew D
> <matthew.d.roper@...el.com>; Deak, Imre <imre.deak@...el.com>;
> Shankar, Uma <uma.shankar@...el.com>; Nautiyal, Ankit K
> <ankit.k.nautiyal@...el.com>; Linux Kernel Mailing List <linux-
> kernel@...r.kernel.org>
> Subject: Re: [Intel-gfx] [RFC][PATCH 5/5] drm/i915/display: Add Nearest-
> neighbor based integer scaling support
> 
> Hi,
> 
> On Tue, 25 Feb 2020 at 07:17, Pankaj Bharadiya
> <pankaj.laxminarayan.bharadiya@...el.com> wrote:
> > @@ -415,18 +415,26 @@ skl_program_scaler(struct intel_plane *plane,
> >         u16 y_vphase, uv_rgb_vphase;
> >         int hscale, vscale;
> >         const struct drm_plane_state *state = &plane_state->uapi;
> > +       u32 src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
> > +       u32 src_h = drm_rect_height(&plane_state->uapi.src) >> 16;
> >         u32 scaling_filter = PS_FILTER_MEDIUM;
> > +       struct drm_rect dst;
> >
> >         if (state->scaling_filter ==
> DRM_SCALING_FILTER_NEAREST_NEIGHBOR) {
> >                 scaling_filter = PS_FILTER_PROGRAMMED;
> > +               skl_setup_nearest_neighbor_filter(dev_priv, pipe,
> > + scaler_id);
> > +
> > +               /* Make the scaling window size to integer multiple of source
> > +                * TODO: Should userspace take desision to round scaling window
> > +                * to integer multiple?
> > +                */
> > +               crtc_w = rounddown(crtc_w, src_w);
> > +               crtc_h = rounddown(crtc_h, src_h);
> 
> The kernel should absolutely not be changing the co-ordinates that
> userspace requested.

Thanks, Will get rid of this in V2.

Thanks,
Pankaj
> 
> Cheers,
> Daniel