linux-kernel - Re: [PATCH v4 2/5] MIPS: DTS: CI20: fix PMU definitions for ACT8600

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Feb 2020 16:33:21 -0300
From:   Paul Cercueil <paul@...pouillou.net>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Paul Boddie <paul@...die.org.uk>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kees Cook <keescook@...omium.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com, stable@...r.kernel.org
Subject: Re: [PATCH v4 2/5] MIPS: DTS: CI20: fix PMU definitions for ACT8600

Hi Nikolaus,


Le sam., févr. 29, 2020 at 19:58, H. Nikolaus Schaller 
<hns@...delico.com> a écrit :
> Hi Paul,
> 
>>  Am 29.02.2020 um 17:09 schrieb Paul Cercueil <paul@...pouillou.net>:
>> 
>>  Hi Nikolaus,
>> 
>> 
>>  Le ven., févr. 28, 2020 at 19:02, H. Nikolaus Schaller 
>> <hns@...delico.com> a écrit :
>>>  There is a ACT8600 on the CI20 board and the bindings of the
>>>  ACT8865 driver have changed without updating the CI20 device
>>>  tree. Therefore the PMU can not be probed successfully and
>>>  is running in power-on reset state.
>>>  Fix DT to match the latest act8865-regulator bindings.
>>>  Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes")
>>>  Cc: stable@...r.kernel.org
>>>  Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>>>  ---
>>>  arch/mips/boot/dts/ingenic/ci20.dts | 48 
>>> ++++++++++++++++++++---------
>>>  1 file changed, 33 insertions(+), 15 deletions(-)
>>>  diff --git a/arch/mips/boot/dts/ingenic/ci20.dts 
>>> b/arch/mips/boot/dts/ingenic/ci20.dts
>>>  index 59c104289ece..44741e927d2b 100644
>>>  --- a/arch/mips/boot/dts/ingenic/ci20.dts
>>>  +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>>>  @@ -4,6 +4,8 @@
>>>  #include "jz4780.dtsi"
>>>  #include <dt-bindings/clock/ingenic,tcu.h>
>>>  #include <dt-bindings/gpio/gpio.h>
>>>  +#include <dt-bindings/interrupt-controller/irq.h>
>> 
>>  This include should be in patch 3/5 where it's first used.
> 
> Yes. That is much better.
> 
>> 
>>  With that fixed:
>>  Reviewed-by: Paul Cercueil <paul@...pouillou.net>
>> 
>>  for the whole series.
> 
> What is easier: that you fix it during applying somewhere
> or should I send a v5?

I guess send a V5.

- Paul

> 
> BR,
> Nikolaus
>