lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 2 Mar 2020 01:52:30 +0000 From: Roy Im <roy.im.opensource@...semi.com> To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Roy Im <roy.im.opensource@...semi.com> CC: Bartosz Golaszewski <bgolaszewski@...libre.com>, Brian Masney <masneyb@...tation.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Greg KH <gregkh@...uxfoundation.org>, Lee Jones <lee.jones@...aro.org>, Luca Weiss <luca@...tu.xyz>, Maximilian Luz <luzmaximilian@...il.com>, Pascal PAILLET-LME <p.paillet@...com>, Rob Herring <robh@...nel.org>, Samuel Ortiz <sameo@...ux.intel.com>, Thierry Reding <thierry.reding@...il.com>, Thomas Gleixner <tglx@...utronix.de>, Support Opensource <Support.Opensource@...semi.com>, "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pwm@...r.kernel.org" <linux-pwm@...r.kernel.org> Subject: RE: [PATCH V9 3/3] Input: new da7280 haptic driver Hello Uwe, On Monday, March 2, 2020 6:20 AM, Uwe Kleine-König wrote: > On Sat, Feb 29, 2020 at 12:59:20AM +0000, Roy Im wrote: > > Okay, thanks. I have tried to update that as below. > > Could I get your comment if you still see anything on this? > > > > /* Maximum gain is 0x7fff for PWM mode */ > > #define MAX_MAGNITUDE_SHIFT 15 > > [...] > > period_mag_multi >>= MAX_MAGNITUDE_SHIFT; > > > > /* The interpretation of duty cycle depends on the acc_en, > > * it should be from 50% to 100% for acc_en = 0. > > * See datasheet 'PWM mode' section for more details. > > */ > > if (!haptics->acc_en) { > > period_mag_multi += state.period; > > period_mag_multi /= 2; > > } > > Much better. Extra points if you add a link to the datasheet at the top of the driver. I didn't look at the datasheet and > assume that the reasoning is obvious then. Okay, then do you think it would be better to remove that comment(the 3rd line - datasheet)?. > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | https://www.pengutronix.de/ | Thanks for your comment. Kind regards, Roy
Powered by blists - more mailing lists