linux-kernel - Re: [PATCH 4/4] video: fbdev: remove set but not used variable 'bytpp'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e060e0a0-1861-20f0-d1ef-6a8137949659@samsung.com>
Date:   Mon, 2 Mar 2020 16:42:30 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     yu kuai <yukuai3@...wei.com>
Cc:     benh@...nel.crashing.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        zhengbin13@...wei.com, yi.zhang@...wei.com
Subject: Re: [PATCH 4/4] video: fbdev: remove set but not used variable
 'bytpp'


On 1/19/20 1:17 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/video/fbdev/aty/radeon_base.c: In function
> ‘radeonfb_set_par’:
> drivers/video/fbdev/aty/radeon_base.c:1660:32: warning:
> variable ‘bytpp’ set but not used [-Wunused-but-set-variable]
> 
> It is never used, and so can be removed.
> 
> Signed-off-by: yu kuai <yukuai3@...wei.com>

Patch queued for v5.7, thanks.
 
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/aty/radeon_base.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c
> index 7d2ee889ffcd..22b3ee4f2ffa 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -1657,7 +1657,7 @@ static int radeonfb_set_par(struct fb_info *info)
>  	int i, freq;
>  	int format = 0;
>  	int nopllcalc = 0;
> -	int hsync_start, hsync_fudge, bytpp, hsync_wid, vsync_wid;
> +	int hsync_start, hsync_fudge, hsync_wid, vsync_wid;
>  	int primary_mon = PRIMARY_MONITOR(rinfo);
>  	int depth = var_to_depth(mode);
>  	int use_rmx = 0;
> @@ -1731,7 +1731,6 @@ static int radeonfb_set_par(struct fb_info *info)
>  		vsync_wid = 0x1f;
>  
>  	format = radeon_get_dstbpp(depth);
> -	bytpp = mode->bits_per_pixel >> 3;
>  
>  	if ((primary_mon == MT_DFP) || (primary_mon == MT_LCD))
>  		hsync_fudge = hsync_fudge_fp[format-1];
>