linux-kernel - Re: [PATCH] video: remove set but not used variable 'ulScaleRight'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b16ece5-a95c-5420-b5d4-7c576171780f@samsung.com>
Date:   Mon, 2 Mar 2020 16:42:34 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     yu kuai <yukuai3@...wei.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhengbin13@...wei.com,
        yi.zhang@...wei.com
Subject: Re: [PATCH] video: remove set but not used variable 'ulScaleRight'


On 1/19/20 1:19 PM, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/video/fbdev/kyro/STG4000OverlayDevice.c: In function
> ‘SetOverlayViewPort’:
> drivers/video/fbdev/kyro/STG4000OverlayDevice.c:334:19: warning:
> variable ‘ulScaleRight’ set but not used [-Wunused-but-set-variable]
> 
> It is never used, and so can be removed.
> 
> Signed-off-by: yu kuai <yukuai3@...wei.com>

Patch queued for v5.7, thanks.
 
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/kyro/STG4000OverlayDevice.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c
> index 0aeeaa10708b..9fde0e3b69ec 100644
> --- a/drivers/video/fbdev/kyro/STG4000OverlayDevice.c
> +++ b/drivers/video/fbdev/kyro/STG4000OverlayDevice.c
> @@ -331,7 +331,7 @@ int SetOverlayViewPort(volatile STG4000REG __iomem *pSTGReg,
>  	u32 ulScale;
>  	u32 ulLeft, ulRight;
>  	u32 ulSrcLeft, ulSrcRight;
> -	u32 ulScaleLeft, ulScaleRight;
> +	u32 ulScaleLeft;
>  	u32 ulhDecim;
>  	u32 ulsVal;
>  	u32 ulVertDecFactor;
> @@ -470,7 +470,6 @@ int SetOverlayViewPort(volatile STG4000REG __iomem *pSTGReg,
>  		 * round down the pixel pos to the nearest 8 pixels.
>  		 */
>  		ulScaleLeft = ulSrcLeft;
> -		ulScaleRight = ulSrcRight;
>  
>  		/* shift fxscale until it is in the range of the scaler */
>  		ulhDecim = 0;
>