[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 3 Mar 2020 13:34:24 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Bartosz Golaszewski <bgolaszewski@...libre.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: Fix inverted check in gpiochip_remove()
On Mon, Mar 2, 2020 at 9:24 AM Geert Uytterhoeven
<geert+renesas@...der.be> wrote:
> The optimization to check for requested lines actually optimized for the
> uncomon error case, where one of the GPIO lines is still in use.
> Hence the error message must be printed when the loop is terminated
> early, not when it went through all available GPIO lines.
>
> Fixes: 869233f81337bfb3 ("gpiolib: Optimize gpiochip_remove() when check for requested line")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
Patch applied with Andy's ACK.
Yours,
Linus Walleij
Powered by blists - more mailing lists