[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200304074719.e6unbgdop2r3jhk2@box>
Date: Wed, 4 Mar 2020 10:47:19 +0300
From: "Kirill A. Shutemov" <kirill@...temov.name>
To: Alex Shi <alex.shi@...ux.alibaba.com>
Cc: cgroups@...r.kernel.org, akpm@...ux-foundation.org,
mgorman@...hsingularity.net, tj@...nel.org, hughd@...gle.com,
khlebnikov@...dex-team.ru, daniel.m.jordan@...cle.com,
yang.shi@...ux.alibaba.com, willy@...radead.org,
hannes@...xchg.org, lkp@...el.com, linux-kernel@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [PATCH v9 04/20] mm/thp: move lru_add_page_tail func to
huge_memory.c
On Mon, Mar 02, 2020 at 07:00:14PM +0800, Alex Shi wrote:
> The func is only used in huge_memory.c, defining it in other file with a
> CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird.
>
> Let's move it close user.
I don't think it's strong enough justification. I would rather keep all
lru helpers in one place.
--
Kirill A. Shutemov
Powered by blists - more mailing lists