[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3b18a429-25fd-df28-1bf3-57bcd38c6cd8@linux.alibaba.com>
Date: Wed, 4 Mar 2020 16:13:43 +0800
From: Alex Shi <alex.shi@...ux.alibaba.com>
To: "Kirill A. Shutemov" <kirill@...temov.name>
Cc: cgroups@...r.kernel.org, akpm@...ux-foundation.org,
mgorman@...hsingularity.net, tj@...nel.org, hughd@...gle.com,
khlebnikov@...dex-team.ru, daniel.m.jordan@...cle.com,
yang.shi@...ux.alibaba.com, willy@...radead.org,
hannes@...xchg.org, lkp@...el.com, linux-kernel@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [PATCH v9 04/20] mm/thp: move lru_add_page_tail func to
huge_memory.c
在 2020/3/4 下午3:47, Kirill A. Shutemov 写道:
> On Mon, Mar 02, 2020 at 07:00:14PM +0800, Alex Shi wrote:
>> The func is only used in huge_memory.c, defining it in other file with a
>> CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird.
>>
>> Let's move it close user.
>
> I don't think it's strong enough justification. I would rather keep all
> lru helpers in one place.
>
Thanks for comments, Kirill,
If it's a common used func, yes.
But if you look into details of this func, it's thp used only func.
Thanks
Alex
Powered by blists - more mailing lists