linux-kernel - Re: [PATCH 4/4] irqchip: Ingenic: Add support for TCU of X1000.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 04 Mar 2020 10:58:38 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     周琰杰 (Zhou Yanjie) 
        <zhouyanjie@...yeetech.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        tglx@...utronix.de, jason@...edaemon.net, sboyd@...nel.org,
        mturquette@...libre.com, mark.rutland@....com, robh+dt@...nel.org,
        daniel.lezcano@...aro.org, paul@...pouillou.net,
        sernia.zhou@...mail.com, zhenwenjin@...il.com,
        dongsheng.qiu@...enic.com
Subject: Re: [PATCH 4/4] irqchip: Ingenic: Add support for TCU of X1000.

On 2020-02-19 08:29, 周琰杰 wrote:
> X1000 has a different TCU containing OST, since X1000, OST has been
> independent of TCU. This patch is prepare for later OST driver.

You keep on talking about OST (whatever that is), but never deals with 
it.
Why don't you just say

"Enable TCU support for Ingenic X1000, which can be supported by
the existing driver."

as this is what the patch is doing?

> 
> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
> ---
>  drivers/irqchip/irq-ingenic-tcu.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/irq-ingenic-tcu.c
> b/drivers/irqchip/irq-ingenic-tcu.c
> index 6d05cef..7a7222d 100644
> --- a/drivers/irqchip/irq-ingenic-tcu.c
> +++ b/drivers/irqchip/irq-ingenic-tcu.c
> @@ -180,3 +180,4 @@ static int __init ingenic_tcu_irq_init(struct
> device_node *np,
>  IRQCHIP_DECLARE(jz4740_tcu_irq, "ingenic,jz4740-tcu", 
> ingenic_tcu_irq_init);
>  IRQCHIP_DECLARE(jz4725b_tcu_irq, "ingenic,jz4725b-tcu", 
> ingenic_tcu_irq_init);
>  IRQCHIP_DECLARE(jz4770_tcu_irq, "ingenic,jz4770-tcu", 
> ingenic_tcu_irq_init);
> +IRQCHIP_DECLARE(x1000_tcu_irq, "ingenic,x1000-tcu", 
> ingenic_tcu_irq_init);

Otherwise,

Acked-by: Marc Zyngier <maz@...nel.org>

I expect this to go via the MIPS tree as a series.

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...