linux-kernel - Re: [PATCH] tools lib traceevent: Remove extra '\n' in print_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Mar 2020 09:59:40 -0300
From:   Arnaldo Carvalho de Melo <acme@...hat.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH] tools lib traceevent: Remove extra '\n' in
 print_event_time()

Em Tue, Mar 03, 2020 at 11:18:52PM -0500, Steven Rostedt escreveu:
> 
> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> 
> If the precesion of print_event_time() is zero or greater than the

precision, right?

Thanks, applied.

- Arnaldo

> timestamp, it uses a different format. But that format had an extra new line
> at the end, and caused the output to not look right:
> 
> cpus=2
>            sleep-3946  [001]111264306005
> : function:             inotify_inode_queue_event
>            sleep-3946  [001]111264307158
> : function:             __fsnotify_parent
>            sleep-3946  [001]111264307637
> : function:             inotify_dentry_parent_queue_event
>            sleep-3946  [001]111264307989
> : function:             fsnotify
>            sleep-3946  [001]111264308401
> : function:             audit_syscall_exit
> 
> Fixes: 38847db9740a ("libtraceevent, perf tools: Changes in tep_print_event_* APIs")
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> ---
>  tools/lib/traceevent/event-parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index beaa8b8c08ff..e1bd2a93c6db 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -5541,7 +5541,7 @@ static void print_event_time(struct tep_handle *tep, struct trace_seq *s,
>  	if (p10 > 1 && p10 < time)
>  		trace_seq_printf(s, "%5llu.%0*llu", time / p10, prec, time % p10);
>  	else
> -		trace_seq_printf(s, "%12llu\n", time);
> +		trace_seq_printf(s, "%12llu", time);
>  }
>  
>  struct print_event_type {
> -- 
> 2.20.1