linux-kernel - Re: [PATCH v3 2/2] xenbus: req->err should be updated before req->state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3bc030fb-340e-434d-60a2-a54bce097680@xen.org>
Date:   Wed, 4 Mar 2020 13:50:51 +0000
From:   Julien Grall <julien@....org>
To:     Dongli Zhang <dongli.zhang@...cle.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Cc:     boris.ostrovsky@...cle.com, jgross@...e.com,
        sstabellini@...nel.org, joe.jin@...cle.com
Subject: Re: [PATCH v3 2/2] xenbus: req->err should be updated before
 req->state

Hi,

On 03/03/2020 22:14, Dongli Zhang wrote:
> This patch adds the barrier to guarantee that req->err is always updated
> before req->state.
> 
> Otherwise, read_reply() would not return ERR_PTR(req->err) but
> req->body, when process_writes()->xb_write() is failed.
> 
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>

Reviewed-by: Julien Grall <jgrall@...zon.com>

Cheers,

---
Julien Grall