linux-kernel - Re: [PATCH v3 2/2] xenbus: req->err should be updated before req->state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8e5b63a-a166-590b-e8ac-3a560b2930c8@oracle.com>
Date:   Fri, 6 Mar 2020 06:13:28 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Dongli Zhang <dongli.zhang@...cle.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Cc:     julien@....org, jgross@...e.com, sstabellini@...nel.org,
        joe.jin@...cle.com
Subject: Re: [PATCH v3 2/2] xenbus: req->err should be updated before
 req->state



On 3/3/20 5:14 PM, Dongli Zhang wrote:
> This patch adds the barrier to guarantee that req->err is always updated
> before req->state.
>
> Otherwise, read_reply() would not return ERR_PTR(req->err) but
> req->body, when process_writes()->xb_write() is failed.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>

Applied to for-linus-5.6b.

-boris