linux-kernel - Re: [PATCH] mm/hugetlb.c: Clean code by removing unnecessary initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87d405de-d73b-9ba9-1644-c2222881ed98@oracle.com>
Date:   Tue, 3 Mar 2020 18:20:47 -0800
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     mateusznosek0@...il.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Cc:     akpm@...ux-foundation.org
Subject: Re: [PATCH] mm/hugetlb.c: Clean code by removing unnecessary
 initialization

On 3/3/20 1:23 PM, mateusznosek0@...il.com wrote:
> From: Mateusz Nosek <mateusznosek0@...il.com>
> 
> Previously variable 'check_addr' was initialized,
> but was not read later before reassigning.
> So the initialization can be removed.
> 
> Signed-off-by: Mateusz Nosek <mateusznosek0@...il.com>

Thanks, that is indeed not needed.
Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>
-- 
Mike Kravetz

> ---
>  mm/hugetlb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index e4116385a4e1..7fb31750e670 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5021,7 +5021,7 @@ static bool vma_shareable(struct vm_area_struct *vma, unsigned long addr)
>  void adjust_range_if_pmd_sharing_possible(struct vm_area_struct *vma,
>  				unsigned long *start, unsigned long *end)
>  {
> -	unsigned long check_addr = *start;
> +	unsigned long check_addr;
>  
>  	if (!(vma->vm_flags & VM_MAYSHARE))
>  		return;
>