linux-kernel - RE: [PATCH] pinctrl: falcon: fix syntax error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Mar 2020 19:11:37 +0000
From:   "Langer, Thomas" <thomas.langer@...el.com>
To:     Mathias Kresin <dev@...sin.me>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>
CC:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] pinctrl: falcon: fix syntax error



> -----Original Message-----
> From: linux-gpio-owner@...r.kernel.org <linux-gpio-
> owner@...r.kernel.org> On Behalf Of Mathias Kresin
> Sent: Donnerstag, 5. März 2020 19:23
> To: linus.walleij@...aro.org
> Cc: linux-gpio@...r.kernel.org; linux-kernel@...r.kernel.org;
> stable@...r.kernel.org
> Subject: [PATCH] pinctrl: falcon: fix syntax error
> 
> Add the missing semicolon after of_node_put to get the file compiled.
> 
> Fixes: f17d2f54d36d ("pinctrl: falcon: Add of_node_put() before
> return")
> Cc: stable@...r.kernel.org # v5.4+
> Signed-off-by: Mathias Kresin <dev@...sin.me>

Acked-by: Thomas Langer <thomas.langer@...el.com>

> ---
>  drivers/pinctrl/pinctrl-falcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-falcon.c
> b/drivers/pinctrl/pinctrl-falcon.c
> index a454f57c264e..62c02b969327 100644
> --- a/drivers/pinctrl/pinctrl-falcon.c
> +++ b/drivers/pinctrl/pinctrl-falcon.c
> @@ -451,7 +451,7 @@ static int pinctrl_falcon_probe(struct
> platform_device *pdev)
>  		falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL);
>  		if (IS_ERR(falcon_info.clk[*bank])) {
>  			dev_err(&ppdev->dev, "failed to get clock\n");
> -			of_node_put(np)
> +			of_node_put(np);
>  			return PTR_ERR(falcon_info.clk[*bank]);
>  		}
>  		falcon_info.membase[*bank] = devm_ioremap_resource(&pdev-
> >dev,
> --
> 2.17.1