linux-kernel - Re: [PATCH v2] power: supply: Allow charger manager can be built as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Mar 2020 21:47:12 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Baolin Wang <baolin.wang7@...il.com>
Cc:     orsonzhai@...il.com, zhang.lyra@...il.com, saravanak@...gle.com,
        kernel-team@...roid.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] power: supply: Allow charger manager can be built as
 a module

Hi,

On Fri, Mar 06, 2020 at 10:34:10AM +0800, Baolin Wang wrote:
> Allow charger manager can be built as a module like other charger
> drivers.
> 
> Signed-off-by: Baolin Wang <baolin.wang7@...il.com>
> ---

Thanks, queued. I do not like this driver, but its the best we have
at the moment.

-- Sebastian

> Changes from v1:
>  - Use IS_ENABLED() instead.
> ---
>  drivers/power/supply/Kconfig          | 2 +-
>  include/linux/power/charger-manager.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
> index 9a5591a..195bc04 100644
> --- a/drivers/power/supply/Kconfig
> +++ b/drivers/power/supply/Kconfig
> @@ -480,7 +480,7 @@ config CHARGER_GPIO
>  	  called gpio-charger.
>  
>  config CHARGER_MANAGER
> -	bool "Battery charger manager for multiple chargers"
> +	tristate "Battery charger manager for multiple chargers"
>  	depends on REGULATOR
>  	select EXTCON
>  	help
> diff --git a/include/linux/power/charger-manager.h b/include/linux/power/charger-manager.h
> index ad19e68..ae94dce 100644
> --- a/include/linux/power/charger-manager.h
> +++ b/include/linux/power/charger-manager.h
> @@ -248,7 +248,7 @@ struct charger_manager {
>  	u64 charging_end_time;
>  };
>  
> -#ifdef CONFIG_CHARGER_MANAGER
> +#if IS_ENABLED(CONFIG_CHARGER_MANAGER)
>  extern void cm_notify_event(struct power_supply *psy,
>  				enum cm_event_types type, char *msg);
>  #else
> -- 
> 1.9.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)