lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 6 Mar 2020 21:47:34 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Ashish Chavan <ashish.gschavan@...il.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: ab8500_charger: Fix typos in commit
 messages

Hi,

On Wed, Feb 26, 2020 at 11:22:23PM +0530, Ashish Chavan wrote:
> Trivial fix to spelling mistake in commit messages.
> 
> Signed-off-by: Ashish Chavan <ashish.gschavan@...il.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/ab8500_charger.c | 35 +++++++++++++++------------
>  1 file changed, 19 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index 98b335042ba6..65741bab8552 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -398,7 +398,7 @@ static void ab8500_enable_disable_sw_fallback(struct ab8500_charger *di,
>  }
>  
>  /**
> - * ab8500_power_supply_changed - a wrapper with local extentions for
> + * ab8500_power_supply_changed - a wrapper with local extensions for
>   * power_supply_changed
>   * @di:	  pointer to the ab8500_charger structure
>   * @psy:  pointer to power_supply_that have changed.
> @@ -677,7 +677,7 @@ static int ab8500_charger_max_usb_curr(struct ab8500_charger *di,
>  	/*
>  	 * Platform only supports USB 2.0.
>  	 * This means that charging current from USB source
> -	 * is maximum 500 mA. Every occurence of USB_STAT_*_HOST_*
> +	 * is maximum 500 mA. Every occurrence of USB_STAT_*_HOST_*
>  	 * should set USB_CH_IP_CUR_LVL_0P5.
>  	 */
>  
> @@ -1372,13 +1372,13 @@ static int ab8500_charger_ac_en(struct ux500_charger *charger,
>  
>  		/*
>  		 * Due to a bug in AB8500, BTEMP_HIGH/LOW interrupts
> -		 * will be triggered everytime we enable the VDD ADC supply.
> +		 * will be triggered every time we enable the VDD ADC supply.
>  		 * This will turn off charging for a short while.
>  		 * It can be avoided by having the supply on when
>  		 * there is a charger enabled. Normally the VDD ADC supply
> -		 * is enabled everytime a GPADC conversion is triggered. We will
> -		 * force it to be enabled from this driver to have
> -		 * the GPADC module independant of the AB8500 chargers
> +		 * is enabled every time a GPADC conversion is triggered.
> +		 * We will force it to be enabled from this driver to have
> +		 * the GPADC module independent of the AB8500 chargers
>  		 */
>  		if (!di->vddadc_en_ac) {
>  			ret = regulator_enable(di->regu);
> @@ -1448,7 +1448,7 @@ static int ab8500_charger_ac_en(struct ux500_charger *charger,
>  		if (is_ab8500_1p1_or_earlier(di->parent)) {
>  			/*
>  			 * For ABB revision 1.0 and 1.1 there is a bug in the
> -			 * watchdog logic. That means we have to continously
> +			 * watchdog logic. That means we have to continuously
>  			 * kick the charger watchdog even when no charger is
>  			 * connected. This is only valid once the AC charger
>  			 * has been enabled. This is a bug that is not handled
> @@ -1545,13 +1545,13 @@ static int ab8500_charger_usb_en(struct ux500_charger *charger,
>  
>  		/*
>  		 * Due to a bug in AB8500, BTEMP_HIGH/LOW interrupts
> -		 * will be triggered everytime we enable the VDD ADC supply.
> +		 * will be triggered every time we enable the VDD ADC supply.
>  		 * This will turn off charging for a short while.
>  		 * It can be avoided by having the supply on when
>  		 * there is a charger enabled. Normally the VDD ADC supply
> -		 * is enabled everytime a GPADC conversion is triggered. We will
> -		 * force it to be enabled from this driver to have
> -		 * the GPADC module independant of the AB8500 chargers
> +		 * is enabled every time a GPADC conversion is triggered.
> +		 * We will force it to be enabled from this driver to have
> +		 * the GPADC module independent of the AB8500 chargers
>  		 */
>  		if (!di->vddadc_en_usb) {
>  			ret = regulator_enable(di->regu);
> @@ -1575,7 +1575,10 @@ static int ab8500_charger_usb_en(struct ux500_charger *charger,
>  			return -ENXIO;
>  		}
>  
> -		/* ChVoltLevel: max voltage upto which battery can be charged */
> +		/*
> +		 * ChVoltLevel: max voltage up to which battery can be
> +		 * charged
> +		 */
>  		ret = abx500_set_register_interruptible(di->dev, AB8500_CHARGER,
>  			AB8500_CH_VOLT_LVL_REG, (u8) volt_index);
>  		if (ret) {
> @@ -2007,7 +2010,7 @@ static void ab8500_charger_check_hw_failure_work(struct work_struct *work)
>   * Work queue function for kicking the charger watchdog.
>   *
>   * For ABB revision 1.0 and 1.1 there is a bug in the watchdog
> - * logic. That means we have to continously kick the charger
> + * logic. That means we have to continuously kick the charger
>   * watchdog even when no charger is connected. This is only
>   * valid once the AC charger has been enabled. This is
>   * a bug that is not handled by the algorithm and the
> @@ -2255,7 +2258,7 @@ static void ab8500_charger_usb_link_status_work(struct work_struct *work)
>  	 * Some chargers that breaks the USB spec is
>  	 * identified as invalid by AB8500 and it refuse
>  	 * to start the charging process. but by jumping
> -	 * thru a few hoops it can be forced to start.
> +	 * through a few hoops it can be forced to start.
>  	 */
>  	if (is_ab8500(di->parent))
>  		ret = abx500_get_register_interruptible(di->dev, AB8500_USB,
> @@ -3214,7 +3217,7 @@ static int ab8500_charger_resume(struct platform_device *pdev)
>  
>  	/*
>  	 * For ABB revision 1.0 and 1.1 there is a bug in the watchdog
> -	 * logic. That means we have to continously kick the charger
> +	 * logic. That means we have to continuously kick the charger
>  	 * watchdog even when no charger is connected. This is only
>  	 * valid once the AC charger has been enabled. This is
>  	 * a bug that is not handled by the algorithm and the
> @@ -3451,7 +3454,7 @@ static int ab8500_charger_probe(struct platform_device *pdev)
>  
>  	/*
>  	 * For ABB revision 1.0 and 1.1 there is a bug in the watchdog
> -	 * logic. That means we have to continously kick the charger
> +	 * logic. That means we have to continuously kick the charger
>  	 * watchdog even when no charger is connected. This is only
>  	 * valid once the AC charger has been enabled. This is
>  	 * a bug that is not handled by the algorithm and the
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ