linux-kernel - Re: [PATCH v2] mfd: syscon: Use a unique name with regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5efbb3c4-044d-0a8e-630a-0dd559f20669@ti.com>
Date:   Thu, 5 Mar 2020 18:29:47 -0600
From:   Suman Anna <s-anna@...com>
To:     Lee Jones <lee.jones@...aro.org>, Arnd Bergmann <arnd@...db.de>
CC:     David Lechner <david@...hnology.com>,
        Tony Lindgren <tony@...mide.com>,
        Roger Quadros <rogerq@...com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v2] mfd: syscon: Use a unique name with regmap_config

On 2/24/20 4:00 AM, Lee Jones wrote:
> On Mon, 27 Jan 2020, Suman Anna wrote:
> 
>> The DT node full name is currently being used in regmap_config
>> which in turn is used to create the regmap debugfs directories.
>> This name however is not guaranteed to be unique and the regmap
>> debugfs registration can fail in the cases where the syscon nodes
>> have the same unit-address but are present in different DT node
>> hierarchies. Replace this logic using the syscon reg resource
>> address instead (inspired from logic used while creating platform
>> devices) to ensure a unique name is given for each syscon.
>>
>> Signed-off-by: Suman Anna <s-anna@...com>
>> ---
>> v2: Fix build warning reported by kbuild test bot
>> v1: https://patchwork.kernel.org/patch/11346363/
>>
>>  drivers/mfd/syscon.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> Waiting for Arnd to review.
> 

Hi Arnd,

Gentle ping, any comments?

regards
Suman