[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200724160641.GB1850026@dell>
Date: Fri, 24 Jul 2020 17:06:41 +0100
From: Lee Jones <lee.jones@...aro.org>
To: Suman Anna <s-anna@...com>
Cc: Arnd Bergmann <arnd@...db.de>,
David Lechner <david@...hnology.com>,
Tony Lindgren <tony@...mide.com>,
Roger Quadros <rogerq@...com>, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH v2] mfd: syscon: Use a unique name with regmap_config
On Mon, 24 Feb 2020, Lee Jones wrote:
> On Mon, 27 Jan 2020, Suman Anna wrote:
>
> > The DT node full name is currently being used in regmap_config
> > which in turn is used to create the regmap debugfs directories.
> > This name however is not guaranteed to be unique and the regmap
> > debugfs registration can fail in the cases where the syscon nodes
> > have the same unit-address but are present in different DT node
> > hierarchies. Replace this logic using the syscon reg resource
> > address instead (inspired from logic used while creating platform
> > devices) to ensure a unique name is given for each syscon.
> >
> > Signed-off-by: Suman Anna <s-anna@...com>
> > ---
> > v2: Fix build warning reported by kbuild test bot
> > v1: https://patchwork.kernel.org/patch/11346363/
> >
> > drivers/mfd/syscon.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Waiting for Arnd to review.
Still waiting for some input from Arnd.
Might be worth submitting a [RESEND].
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists