linux-kernel - Re: [failures] mm-vmscan-remove-unnecessary-lruvec-adding.patch removed from -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b123f1d8-eab0-4689-9400-ba1f853728b7@linux.alibaba.com>
Date:   Fri, 6 Mar 2020 17:04:20 +0800
From:   Alex Shi <alex.shi@...ux.alibaba.com>
To:     Qian Cai <cai@....pw>, LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     aarcange@...hat.com, daniel.m.jordan@...cle.com,
        hannes@...xchg.org, hughd@...gle.com, khlebnikov@...dex-team.ru,
        kirill@...temov.name, kravetz@...ibm.com, mhocko@...nel.org,
        mm-commits@...r.kernel.org, tj@...nel.org, vdavydov.dev@...il.com,
        willy@...radead.org, yang.shi@...ux.alibaba.com
Subject: Re: [failures] mm-vmscan-remove-unnecessary-lruvec-adding.patch
 removed from -mm tree



在 2020/3/6 上午11:32, Qian Cai 写道:
> 
>> On Mar 5, 2020, at 9:50 PM, akpm@...ux-foundation.org wrote:
>>
>>
>> The patch titled
>>     Subject: mm/vmscan: remove unnecessary lruvec adding
>> has been removed from the -mm tree.  Its filename was
>>     mm-vmscan-remove-unnecessary-lruvec-adding.patch
>>
>> This patch was dropped because it had testing failures
> Andrew, do you have more information about this failure? I hit a bug
> here under memory pressure and am wondering if this is related
> which might save me some time digging…
> 
> [ 4389.727184][ T6600] mem_cgroup_update_lru_size(00000000bb31aaed, 0, -7): lru_size -1

This bug seems failed due to a update_lru_size() missing or misplace, but
what's I changed on this patch seems unlike to cause this bug.

Anyway, Qian, could you do me a favor to remove this patch and try again?
Since I am trying ltp's oom01 case,
# i=0; while :; do echo $((i++)); oom01; sleep 5; done
It runs well in dozens times on my qemu and hardware machine, on akpm branch commit f2cbd107a99b,
which included my 6 patches.


Andrew,

What's the reproduce steps for this test failure?

Thanks a lot for everyone!
Alex