linux-kernel - Re: [PATCH v2 3/6] irq/domain: add a new callback to domain ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 8 Mar 2020 13:51:17 +0000
From:   Marc Zyngier <maz@...nel.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v2 3/6] irq/domain: add a new callback to domain ops

On Tue, 11 Feb 2020 14:12:37 +0100
Bartosz Golaszewski <brgl@...ev.pl> wrote:

> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> Add the remove() callback to irq_domain_ops which can be used to
> automatically dispose of any host data associated with the domain when
> irq_domain_remove() is called.

I have a hard time buying this. Whatever data that is associated to the
domain is already owned known by whoever created the domain the first
place.

Since the expected use case is that whoever created the domain also
destroys it, the caller is already in a position to do its own cleanup,
and we don't need any of this.

So please explain what you are trying to achieve here.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...