lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 8 Mar 2020 15:46:04 +0100 From: Lubomir Rintel <lkundrak@...sk> To: Marc Zyngier <maz@...nel.org> Cc: Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org> Subject: Re: [PATCH 0/2] irqchip/mmp: A pair of robustness fixed On Sun, Mar 08, 2020 at 02:04:34PM +0000, Marc Zyngier wrote: > On Wed, 19 Feb 2020 09:00:22 +0100 > Lubomir Rintel <lkundrak@...sk> wrote: > > [+RobH] > > Lubomir, > > > Hi, > > > > please consider applying these two patches. Thery are not strictly > > necessary, but improve diagnostics in case the DT is faulty. > > Can't we instead make sure our DT infrastructure checks for these? I'm > very reluctant to add more "DT validation" to the kernel, as it feels > like the wrong place to do this. These are not really problems of the DT infrastructure. It's that the driver has some constrains resulting from use of global data ([PATCH 1]) and statically sized arrays ([PATCH 2]) without enforcing them. It's probably easier to mess up DT than to mess up board files, but regardless of that, being a little defensive and checking the bounds of arrays is probably a good programming practice anyways. Thank you Lubo
Powered by blists - more mailing lists