linux-kernel - Re: [PATCH] drivers: virtio: Make out_del_vqs dependent on BALLOON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4AB99BBC-0EC7-40F0-96ED-04796A73CBA2@redhat.com>
Date:   Sun, 8 Mar 2020 20:38:19 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Vincenzo Frascino <vincenzo.frascino@....com>
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>
Subject: Re: [PATCH] drivers: virtio: Make out_del_vqs dependent on BALLOON_COMPACTION



> Am 06.03.2020 um 11:56 schrieb Vincenzo Frascino <vincenzo.frascino@....com>:
> 
> out_del_vqs label is currently used only when BALLOON_COMPACTION
> configuration option is enabled. Having it disabled triggers the
> following warning at compile time:
> 
> drivers/virtio/virtio_balloon.c: In function ‘virtballoon_probe’:
> drivers/virtio/virtio_balloon.c:963:1: warning: label ‘out_del_vqs’
> defined but not used [-Wunused-label]
>  963 | out_del_vqs:
>      | ^~~~~~~~~~~
> 
> Make out_del_vqs dependent on BALLOON_COMPACTION to address the
> issue.
> 
> Cc: "Michael S. Tsirkin" <mst@...hat.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>

I think this is now the third patch on the list that tries to fix this warning.

Michael, can we finally queue one of these (or is there one in -next already - did not check)?

Thanks